javascript - Make form validation return true? -


here validation code:

 function validateenquiryform() { var x = document.forms["enquiry"]["name"].value; if(x == null || x == "" || x == "name") { $('#name').removeclass('custom').addclass('error'); $('.name-error').show(); //return false; } else if(x !== null || x !== "" || x !== "name") { $('#name').removeclass('error').addclass('custom'); $('.name-error').hide(); } var x = document.forms["enquiry"]["phone"].value; if(x == null || x == "" || x == "phone number") { $('#phone').removeclass('custom').addclass('error'); $('.phone-error').show(); //return false; } else if(x !== null || x !== "" || x !== "phone number") { $('#phone').removeclass('error').addclass('custom'); $('.phone-error').hide(); } var x = document.forms["enquiry"]["requirements"].value; if(x == null || x == "" || x == "add other requirements here...") { $('#requirements').removeclass('textarea-1').addclass('error'); $('.requirements-error').show(); //return false; } else if(x !== null || x !== "" || x !== "add other requirements here...") { $('#requirements').removeclass('error').addclass('custom'); $('.requirements-error').hide(); } var x = document.forms["enquiry"]["summary"].value; if(x == null || x == "" || x == "summarise project in few key words...") { $('#summary').removeclass('custom').addclass('error'); $('.summary-error').show(); //return false; } else if(x !== null || x !== "" || x !== "summarise project in few key words...") { $('#summary').removeclass('error').addclass('custom'); $('.summary-error').hide(); } var x = document.forms["enquiry"]["email"].value; var atpos = x.indexof("@"); var dotpos = x.lastindexof("."); if(atpos < 1 || dotpos < atpos + 2 || dotpos + 2 >= x.length) { $('#email').removeclass('custom').addclass('error'); $('.email-error').show(); //return false; } else if(atpos > 1 || dotpos > atpos + 2 || dotpos + 2 <= x.length) { $('#email').removeclass('error').addclass('custom'); $('.email-error').hide(); } $('.error-banner').effect("pulsate", { times: 2 }, 1000); return false; }

when code runs checks fields see if blank. if 1 or more incorrectly filled in .error-bannerpulses , individual messages displayed. problem when form filled in correctly banner still flashes. tell me going wrong..?

as far can tell, function ends block, unconditionally:

$('.error-banner').effect("pulsate", { times: 2 }, 1000); return false;

maybe change to:

var valid = true; // in error handling conditionals, set valid false: if(x == null || x == "" || x == "phone number") { $('#phone').removeclass('custom').addclass('error'); $('.phone-error').show(); valid = false; } ... if (!valid) { $('.error-banner').effect("pulsate", { times: 2 }, 1000); } return valid;

i have agree majority of commenters approach leaves lot of room improvement, though.


Comments

Post a Comment

Popular posts from this blog

javascript - backbone.js Collection.add() doesn't `construct` (`initialize`) an object -

<!doctype html public "-//w3c//dtd xhtml 1.0 strict//en" "http://www.w3.org/tr/xhtml1/dtd/xhtml1-strict.dtd"> <html> <head> <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.7.2/jquery.min.js"></script> <script src="http://documentcloud.github.com/underscore/underscore-min.js"></script> <script src="http://documentcloud.github.com/backbone/backbone-min.js"></script> </head> <body> <button id="cmd_create_event" name="cmd_create_event" type="button">create new `event`</button> <script type="text/javascript"> var eventmodel = backbone.model.extend({ initialize : function() { console.log("`event` initialized. id: " + this.cid); this.bind("change:status", function() { console.log(this.get("status") + " value `status`"); }); this.bind("error", function(model, e...
Read more

php - Get uncommon values from two or more arrays -

is there function in php give array of uncommon values 2 or more arrays? for example: $array1 = array( "green", "red", "blue"); $array2 = array( "green", "yellow", "red"); .... $result = function_needed($array1, $array2,...); print_r($result); should give output: array("blue", "yellow", ...); use array_diff , array_merge : $result = array_merge(array_diff($array1, $array2), array_diff($array2, $array1)); here's demo. for multiple arrays, combine callback , array_reduce : function unique(&$a, $b) { return $a ? array_merge(array_diff($a, $b), array_diff($b, $a)) : $b; } $arrays = array( array('green', 'red', 'blue'), array('green', 'yellow', 'red') ); $result = array_reduce($arrays, 'unique'); and here's demo of that.
Read more

Adding duplicate array rows in Php -

i create function in php adds rows of array shared column value. so input. $test = array( array("c", 5, 6), array("c", 2, 3), array("test", 5, 6) ); and output. $testduplicatefree = array( array("c", 7, 9), array("test", 5, 6) ) ); i'm thinking function combine_duplicates($array,$col){ ... ... return $duplicatefreearray; } where $col duplicate free array. so, in case, combine_duplicates($test,0); would me desired output. this. <?php function combine_duplicates($array,$col) { $index = array(); foreach ($array $row) { $key = $row[$col]; if (!isset($index[$key])) { $index[$key] = $row; } else { ($i = 0; $i < count($row); ++$i) { if ($i != $col) { $index[$key][$i] += $row[$i]; } } } } return array_values($index); } $array = array( array("c", 5, 6), array("c", 2, 3), array("test", 5, 6) ); print_r(combine_duplicates($array, 0)); try here: http://codepad.org/mdhesqhi
Read more