javascript - Splice only working part of the time -


here have array undefined number of elements. tried print random element of array , cut it. here code.

function rand(min, max){ return (math.floor(math.random() * (max - min + 1)) + min).tofixed(0); } $('#do').click(function(){ var count = chamarr.length; var num = 0; if (count == 1) { $('#output').html('nothing can found'); } else { num = rand(1,chamarr.length); $('#output').html(chamarr[num]); chamarr.splice(num,1); } });

when logged array cutted, saw ok, element not cut!

my guess problem randnum method:

function rand(min, max){ return (math.floor(math.random() * (max - min + 1)) + min).tofixed(0); }

i believe give value in range [min, max] - inclusive @ both ends. (well, actually, give string version of value tofixed returns string, when use later it'll coerced number.)

now you're calling this:

num = rand(1,chamarr.length);

so if array 6 elements long, you'll value in range [1, 6]. you'll try take chamarr[num] - , range of valid indexes [0, 5] arrays 0-based. if try take element 6, give undefined - splicing @ element 6 won't anything.

i change rand method exclusive @ upper bound, this:

function rand(min, max) { return (math.floor(math.random() * (max - min)) + min).tofixed(0); }

and call this:

num = rand(0, chamarr.length);

that give value in right range both indexing , splicing.

edit: in response comments etc:

  • it's worth removing tofixed(0) part of rand function; don't really want string, after all. isn't part of wrong before, it's cleaner:

    function rand(min, max) { return math.floor(math.random() * (max - min)) + min; }

  • you might want version of function makes 0 lower bound implicit

  • if you're not going use random numbers anywhere else in code could inline math.floor() / math.random() calls instead of having separate function, i'd want keep them away "logic" code wants random number , use it.
  • the reason i'd change function having exclusive upper bound more common in computer science - typically goes along 0-indexing things collections. typically write for loops inclusive lower bounds , exclusive lower bounds, etc.

Comments

Post a Comment

Popular posts from this blog

javascript - backbone.js Collection.add() doesn't `construct` (`initialize`) an object -

<!doctype html public "-//w3c//dtd xhtml 1.0 strict//en" "http://www.w3.org/tr/xhtml1/dtd/xhtml1-strict.dtd"> <html> <head> <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.7.2/jquery.min.js"></script> <script src="http://documentcloud.github.com/underscore/underscore-min.js"></script> <script src="http://documentcloud.github.com/backbone/backbone-min.js"></script> </head> <body> <button id="cmd_create_event" name="cmd_create_event" type="button">create new `event`</button> <script type="text/javascript"> var eventmodel = backbone.model.extend({ initialize : function() { console.log("`event` initialized. id: " + this.cid); this.bind("change:status", function() { console.log(this.get("status") + " value `status`"); }); this.bind("error", function(model, e...
Read more

c++ - Accessing inactive union member and undefined behavior? -

i under impression accessing union member other last 1 set ub, can't seem find solid reference (other answers claiming it's ub without support standard). so, undefined behavior? the confusion c explicitly permits type-punning through union, whereas c++ ( c++11 ) has no such permission. c11 6.5.2.3 structure , union members 95) if member used read contents of union object not same member last used store value in object, appropriate part of object representation of value reinterpreted object representation in new type described in 6.2.6 (a process called ‘‘type punning’’). might trap representation. the situation c++: c++11 9.5 unions [class.union] in union, @ 1 of non-static data members can active @ time, is, value of @ 1 of non-static data members can stored in union @ time. c++ later has language permitting use of unions containing struct s common initial sequences; doesn't permit type-punning. to determine whether union type-punning is allowe...
Read more

php - Get uncommon values from two or more arrays -

is there function in php give array of uncommon values 2 or more arrays? for example: $array1 = array( "green", "red", "blue"); $array2 = array( "green", "yellow", "red"); .... $result = function_needed($array1, $array2,...); print_r($result); should give output: array("blue", "yellow", ...); use array_diff , array_merge : $result = array_merge(array_diff($array1, $array2), array_diff($array2, $array1)); here's demo. for multiple arrays, combine callback , array_reduce : function unique(&$a, $b) { return $a ? array_merge(array_diff($a, $b), array_diff($b, $a)) : $b; } $arrays = array( array('green', 'red', 'blue'), array('green', 'yellow', 'red') ); $result = array_reduce($arrays, 'unique'); and here's demo of that.
Read more