c# - New to programming how to make this code more concise -


hi first question apologies if basic - new programming!!! using c# in mvc trying select object has date property entitymodel context. date selects relevant weight object , on list of "set" objects.

the code works , want general guidance on how make code more concise. here code: 

 public actionresult showdiary(string datein) { localtestentities1 dblists = new localtestentities1(); datetime date = convert.todatetime(datein); ienumerable<exercisediary> diary = o in dblists.exercisediaries o.date == date select o; var mydiary = diary.tolist(); exercisediary thediary = mydiary[0]; iqueryable<weight> weights = o in dblists.weights o.diaryid == thediary.id select o; var selectedweight = weights.tolist(); weight weight = selectedweight[0]; ienumerable<set> sets = x in dblists.sets x.weightid == weight.weightid select x; return view(sets); }

it seems taking many steps here. know returning 1 object diary. there way object dblists without sending ienumerable?

there's many ways things, but... think easiest way use first() since grabbing first result in list.

another way make little cleaner put linq statements on multiple lines did sets.

you can use var, people , others don't have compiler infer type. did sets below. feel cleans code bit when have large declarations ienumerable , generics.

public actionresult showdiary(string datein) { localtestentities1 dblists = new localtestentities1(); datetime date = convert.todatetime(datein); exercisediary thediary = dblists.exercisediaries.first(o => o.date == date); weight weight = dblists.weights.first(o.diaryid == thediary.id); var sets = x in dblists.sets x.weightid == weight.weightid select x; return view(sets); }

imo easier read had in answer above.


Comments

Post a Comment

Popular posts from this blog

javascript - backbone.js Collection.add() doesn't `construct` (`initialize`) an object -

<!doctype html public "-//w3c//dtd xhtml 1.0 strict//en" "http://www.w3.org/tr/xhtml1/dtd/xhtml1-strict.dtd"> <html> <head> <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.7.2/jquery.min.js"></script> <script src="http://documentcloud.github.com/underscore/underscore-min.js"></script> <script src="http://documentcloud.github.com/backbone/backbone-min.js"></script> </head> <body> <button id="cmd_create_event" name="cmd_create_event" type="button">create new `event`</button> <script type="text/javascript"> var eventmodel = backbone.model.extend({ initialize : function() { console.log("`event` initialized. id: " + this.cid); this.bind("change:status", function() { console.log(this.get("status") + " value `status`"); }); this.bind("error", function(model, e...
Read more

php - Get uncommon values from two or more arrays -

is there function in php give array of uncommon values 2 or more arrays? for example: $array1 = array( "green", "red", "blue"); $array2 = array( "green", "yellow", "red"); .... $result = function_needed($array1, $array2,...); print_r($result); should give output: array("blue", "yellow", ...); use array_diff , array_merge : $result = array_merge(array_diff($array1, $array2), array_diff($array2, $array1)); here's demo. for multiple arrays, combine callback , array_reduce : function unique(&$a, $b) { return $a ? array_merge(array_diff($a, $b), array_diff($b, $a)) : $b; } $arrays = array( array('green', 'red', 'blue'), array('green', 'yellow', 'red') ); $result = array_reduce($arrays, 'unique'); and here's demo of that.
Read more

Adding duplicate array rows in Php -

i create function in php adds rows of array shared column value. so input. $test = array( array("c", 5, 6), array("c", 2, 3), array("test", 5, 6) ); and output. $testduplicatefree = array( array("c", 7, 9), array("test", 5, 6) ) ); i'm thinking function combine_duplicates($array,$col){ ... ... return $duplicatefreearray; } where $col duplicate free array. so, in case, combine_duplicates($test,0); would me desired output. this. <?php function combine_duplicates($array,$col) { $index = array(); foreach ($array $row) { $key = $row[$col]; if (!isset($index[$key])) { $index[$key] = $row; } else { ($i = 0; $i < count($row); ++$i) { if ($i != $col) { $index[$key][$i] += $row[$i]; } } } } return array_values($index); } $array = array( array("c", 5, 6), array("c", 2, 3), array("test", 5, 6) ); print_r(combine_duplicates($array, 0)); try here: http://codepad.org/mdhesqhi
Read more